Add configs to specify keepAlive and shutdownTimeout for GrpcQueryClient #13546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankshriv
force-pushed
the
grpc
branch
3 times, most recently
from
565f80e to
bb4b271
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13546 +/- ##
============================================
+ Coverage 61.75% 62.12% +0.37%
+ Complexity 207 198 -9
============================================
Files 2436 2558 +122
Lines 133233 140916 +7683
Branches 20636 21866 +1230
============================================
+ Hits 82274 87543 +5269
- Misses 44911 46741 +1830
- Partials 6048 6632 +584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elonazoulay
approved these changes
Jul 8, 2024
yashmayya
added
the
Configuration
Jackie-Jiang
approved these changes
Jul 8, 2024
pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java
Outdated
Show resolved
Hide resolved
Comment on lines
35
to
41
| // KeepAlive configs | ||
| private static final String CONFIG_CHANNEL_KEEP_ALIVE_ENABLED = "channelKeepAliveEnabled"; | ||
| // To control keep alive on no usage | ||
| private static final boolean DEFAULT_CHANNEL_KEEP_ALIVE_ENABLED = false; | ||
|
|
||
| private static final String CONFIG_CHANNEL_KEEP_ALIVE_TIME_SECONDS = "channelKeepAliveTimeSeconds"; | ||
| private static final int DEFAULT_CHANNEL_KEEP_ALIVE_TIME_SECONDS = 300; // 5 minutes |
There was a problem hiding this comment.
Consider merging this 2? Basically enabling keep alive is equivalent to setting the keep alive time to a positive value
There was a problem hiding this comment.
Updated the PR to keep default value as -1 to indiciate disabled. Users will need to set to > 0 to enable the feature.
pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java
Outdated
Show resolved
Hide resolved
mayankshriv
force-pushed
the
grpc
branch
2 times, most recently
from
52ceccd to
b464d6d
Compare
…ent.
- Added `channelShutdownTimeoutSecond` config for `GrpcQueryClient` with default of 10s.
- Added configs for keep-alive:
- `channelKeepAliveEnabled` to enable/disable the feature, default false.
- `channelKeepAliveTimeiSeconds` to configures the interval for sending keep-alive pings,
default 300 seconds (5 minutes).
- `channelKeepAliveTimeoutSeconds` configures the timeout for waiting for a ping acknowledgment,
default 300 seconds (5 minutes).
- `channelKeepAliveWithoutCalls` ensures pings are sent even when there are no active calls,
keeping the connection alive during idle period, default true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configs to specify keepAlive and shutdownTimeout for
GrpcQueryClient.channelShutdownTimeoutSecondconfig forGrpcQueryClientwith default of 10s.channelKeepAliveEnabledto enable/disable the feature, default false.channelKeepAliveTimeSecondsto configures the interval for sending keep-alive pings, default 300 seconds (5 minutes).channelKeepAliveTimeoutSecondsconfigures the timeout for waiting for a ping acknowledgment, default 300 seconds (5 minutes).channelKeepAliveWithoutCallsensures pings are sent even when there are no active calls, keeping the connection alive during idle period, default true.